Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move files to the new bundle directory structure #826

Merged
merged 1 commit into from
Dec 22, 2023
Merged

Move files to the new bundle directory structure #826

merged 1 commit into from
Dec 22, 2023

Conversation

GromNaN
Copy link
Member

@GromNaN GromNaN commented Dec 21, 2023

Directory structure documented on https://symfony.com/doc/6.4/bundles/best_practices.html

  • move classes to ./src
  • rename Tests folder to ./tests
  • move Resources/doc to ./docs
  • move Resources/config to ./config
  • update config for autoloading, phpcs, phpunit, psalm, ci

@GromNaN GromNaN requested a review from franmomu December 21, 2023 18:03
@GromNaN GromNaN force-pushed the directory-structure branch 3 times, most recently from 2fc71a5 to e1ef9ab Compare December 21, 2023 18:30
@GromNaN GromNaN requested review from alcaeus and malarzm December 21, 2023 18:31
malarzm
malarzm approved these changes Dec 21, 2023
View reviewed changes
Copy link
Member

@malarzm malarzm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah someone motivated enough to do this! :D Love it <3

franmomu
franmomu approved these changes Dec 22, 2023
View reviewed changes
Copy link
Contributor

@franmomu franmomu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙌

@GromNaN GromNaN force-pushed the directory-structure branch from e1ef9ab to baf42da Compare December 22, 2023 08:01
@GromNaN GromNaN merged commit 9cdb4c2 into doctrine:5.0.x Dec 22, 2023
13 checks passed
@GromNaN GromNaN deleted the directory-structure branch December 22, 2023 08:08
@GromNaN
Copy link
Member Author

GromNaN commented Dec 22, 2023

Thank you for your support and quick reviews!

@GromNaN GromNaN added the Task label Dec 22, 2023
@GromNaN GromNaN added this to the 5.0.0 milestone Dec 22, 2023
@GromNaN GromNaN mentioned this pull request Dec 22, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@malarzm malarzm malarzm approved these changes

@franmomu franmomu franmomu approved these changes

@alcaeus alcaeus Awaiting requested review from alcaeus

Assignees
No one assigned
Labels
Task
Projects
None yet
Milestone
5.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@GromNaN @franmomu @malarzm