Remove deprecated configuration #819
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GromNaN
commented
Dec 19, 2023
| @@ -276,7 +273,7 @@ public static function provideMergeOptions(): array | |||
| // the "options" array is totally replaced | |||
| $cases[] = [ | |||
| [ | |||
| ['connections' => ['default' => ['options' => ['timeout' => 2000]]]], | |||
| ['connections' => ['default' => ['options' => ['socketTimeoutMS' => 2000]]]], | |||
There was a problem hiding this comment.
Simply switched to an option that is supported.
GromNaN
commented
Dec 19, 2023
| |--------------------------|-------------|--------------------| | ||
| | `default_commit_options` | `fsync` | `j` | | ||
| | `default_commit_options` | `safe` | `w` | | ||
| | `connections.*.options` | `fsync` | `journal` | |
There was a problem hiding this comment.
I'm not sure if the .*. is the correct notation we use to reference paths with variable parts.
|
A reminder that when #820 is merged in 5.0.x, we should remove the |
GromNaN
force-pushed
the
remove-deprecated-2
branch
from
53c5089 to
e4b423d
Compare
Done, after rebase. |
franmomu
approved these changes
Dec 20, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
default_commit_optionsfsyncjdefault_commit_optionssafewconnections.*.optionsfsyncjournalconnections.*.optionsslaveOkayreadPreferenceconnections.*.optionstimeoutconnectTimeoutMSconnections.*.optionswTimeoutwTimeoutMSFlagged as deprecated in #820