Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate container injection in fixture classes with ContainerAwareInterface #801

Merged
merged 1 commit into from
Dec 11, 2023

Conversation

GromNaN
Copy link
Member

@GromNaN GromNaN commented Dec 10, 2023

ContainerAwareInterface is deprecated since Symfony 6.4. It was used before, for fixture classes that were not defined as services. As all fixture classes must declared as services to be used by the command, proper dependency injection is easy to do.

Let's deprecate this automatic injection and remove it in 5.0 #802

@GromNaN GromNaN added the Task label Dec 10, 2023
@GromNaN GromNaN added this to the 4.7.0 milestone Dec 10, 2023
@GromNaN GromNaN requested a review from franmomu December 10, 2023 18:20
@franmomu franmomu merged commit c53d147 into doctrine:4.7.x Dec 11, 2023
13 checks passed
@franmomu
Copy link
Contributor

thanks @GromNaN!

GromNaN added a commit that referenced this pull request Dec 11, 2023
* 4.7.x:
  Deprecate container injection in fixture classes with ContainerAwareInterface (#801)
@GromNaN GromNaN deleted the deprecate-fixture-container branch December 11, 2023 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants