Remove --service option from doctrine:mongodb:fixtures:load command
#799
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GromNaN
force-pushed
the
fixtures-command
branch
from
0431d95 to
3d87fd6
Compare
GromNaN
commented
Dec 10, 2023
|
|
||
| /** | ||
| * Load data fixtures from bundles. | ||
| */ | ||
| class LoadDataFixturesDoctrineODMCommand extends DoctrineODMCommand | ||
| { | ||
| public function __construct(?ManagerRegistry $registry = null, ?KernelInterface $kernel = null, private ?SymfonyFixturesLoaderInterface $fixturesLoader = null) | ||
| public function __construct(ManagerRegistry $registry, private SymfonyFixturesLoaderInterface $fixturesLoader) | ||
| { | ||
| parent::__construct($registry); | ||
| } | ||
|
|
There was a problem hiding this comment.
The command is removed in the DI extension instead of being disabled, so the code is more centralized and the dependency to the loader can be required in the constructor.
|
LGTM after removing the code in https://github.com/doctrine/DoctrineMongoDBBundle/pull/799/files#diff-3a492b7fded88ef81783ee4a2b12b644854d41a3caf1944dbafb84f8b7dd594fR69 (the one that psalm is complaining) |
GromNaN
force-pushed
the
fixtures-command
branch
2 times, most recently
from
4b74671 to
d6a46e0
Compare
GromNaN
force-pushed
the
fixtures-command
branch
from
d6a46e0 to
22934c5
Compare
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #650
This option was deprecated, using services is the only behavior, used by default.