Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove support of annotations #793

Merged
merged 1 commit into from
Dec 9, 2023

Conversation

franmomu
Copy link
Contributor

@franmomu franmomu commented Dec 9, 2023

No description provided.

@franmomu franmomu added the Task label Dec 9, 2023
@franmomu franmomu added this to the 5.0.0 milestone Dec 9, 2023
<argument type="service" id="doctrine_mongodb.odm.metadata.annotation_reader" />
<argument>%doctrine_mongodb.odm.document_dirs%</argument>
</service>
<service id="doctrine_mongodb.odm.metadata.annotation_reader" alias="annotation_reader" />
<service id="doctrine_mongodb.odm.metadata.attribute" class="%doctrine_mongodb.odm.metadata.attribute.class%">
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm wondering if these services are necessary, I'll try to remove them in another PR

Copy link
Member

@GromNaN GromNaN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@franmomu franmomu force-pushed the remove_support_annotations branch from fff75dc to 7988ce7 Compare December 9, 2023 14:13
@franmomu franmomu merged commit 3c499fb into doctrine:5.0.x Dec 9, 2023
14 checks passed
@franmomu franmomu deleted the remove_support_annotations branch December 9, 2023 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants