-
Notifications
You must be signed in to change notification settings - Fork 231
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove deprecations using Symfony 6.4 #789
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
franmomu
force-pushed
the
test_with_symfony64
branch
from
December 5, 2023 08:28
52b0c81
to
9d65757
Compare
franmomu
force-pushed
the
test_with_symfony64
branch
from
December 5, 2023 08:37
9d65757
to
b09c0e5
Compare
GromNaN
reviewed
Dec 5, 2023
The BC break changes are mandatory if we want to have compatibility with Symfony 7, that's why I targeted |
GromNaN
approved these changes
Dec 9, 2023
Thank you very much @franmomu |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because of symfony/symfony#50391 there are these deprecations:
I've created a second commit to silence these ones, but the changes are not BC, so we have to decide if we are fine with that or we should ignore it for now.
There are some other deprecations that we have to take a look.