Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update first_steps.rst #751

Closed
wants to merge 1 commit into from
Closed

Conversation

bruteforks
Copy link

Not sure if this is the right place, but I was just stuck on this issue for a long time before figuring it out.

Not sure if this is the right place, but I was just stuck on this issue for a long time before figuring it out.
@SenseException
Copy link
Member

Thanks for your PR. Your addition is kind of redundant, because the mentioned types are already named in the documentation. Maybe it makes sense if you set a link to the mapping part instead.

@bruteforks
Copy link
Author

Thanks for your PR. Your addition is kind of redundant, because the mentioned types are already named in the documentation. Maybe it makes sense if you set a link to the mapping part instead.

Took me a day (although new to symfony and doctrine) to figure out that you have to change that obscure config variable for the package to work out of the box. Hopefully it can save someone the hassle. Found fix on SO, so other people have had the same issue: https://stackoverflow.com/a/74084695/1048291

@malarzm
Copy link
Member

malarzm commented Dec 4, 2022

I think the correct way forward is to make attribute the new default (and advertise it in docs, newcomers should use just that), we want to phase out annotations anyway :)

@SenseException
Copy link
Member

I think the correct way forward is to make attribute the new default

I agree. I'm not sure if this PR needs to be worked on now, but because a default attribute won't happen in 4.4, a link still can help people in the meantime.

@franmomu
Copy link
Contributor

franmomu commented Jan 8, 2023

I've created symfony/recipes-contrib#1472 so for new installs it would rely on the default mapping type detected in https://github.com/symfony/symfony/blob/27e6eb493ab6324164eb53e71fef4bda7fe798dc/src/Symfony/Bridge/Doctrine/DependencyInjection/AbstractDoctrineExtension.php#L298

@franmomu
Copy link
Contributor

I think we can close this one as the initial problem I think it was with the Symfony recipe and it was changed in symfony/recipes-contrib#1472

Docs should be change to promote the use of attributes instead of annotations, so I've created #761

thanks @bruteforks for the PR, feel free to reopen if you want to add the link or open a new one.

@franmomu franmomu closed this Jan 13, 2023
@bruteforks
Copy link
Author

@franmomu no problem. glad it helped!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants