Deprecate AsDocumentListener::$method and $lazy (not working)

doctrine · Dec 22, 2023 · 7aa4332 · 7aa4332
1 parent 49bfb83
commit 7aa4332
Show file tree

Hide file tree

Showing 3 changed files with 24 additions and 4 deletions.
diff --git a/Attribute/AsDocumentListener.php b/Attribute/AsDocumentListener.php
@@ -6,6 +6,8 @@
 
 use Attribute;
 
+use function trigger_deprecation;
+
 /**
  * Service tag to autoconfigure document listeners.
  */
@@ -14,10 +16,28 @@ class AsDocumentListener
 {
     public function __construct(
         public ?string $event = null,
+        /** @deprecated the method name is the same as the event name */
         public ?string $method = null,
+        /** @deprecated not supported */
         public ?bool $lazy = null,
         public ?string $connection = null,
         public ?int $priority = null,
     ) {
+        // phpcs:disable SlevomatCodingStandard.ControlStructures.EarlyExit.EarlyExitNotUsed
+        if ($method !== null) {
+            trigger_deprecation(
+                'doctrine/mongodb-odm-bundle',
+                '4.7',
+                'The method name is the same as the event name, so it can be omitted.',
+            );
+        }
+
+        if ($lazy !== null) {
+            trigger_deprecation(
+                'doctrine/mongodb-odm-bundle',
+                '4.7',
+                'Lazy loading is not supported.',
+            );
+        }
     }
 }
diff --git a/Tests/DependencyInjection/DoctrineMongoDBExtensionTest.php b/Tests/DependencyInjection/DoctrineMongoDBExtensionTest.php
@@ -94,8 +94,8 @@ public function testAsDocumentListenerAttribute(): void
         self::assertSame([
             [
                 'event' => 'prePersist',
-                'method' => 'onPrePersist',
-                'lazy' => true,
+                'method' => null,
+                'lazy' => null,
                 'connection' => 'test',
                 'priority' => 10,
             ],

diff --git a/...Injection/Fixtures/Bundles/DocumentListenerBundle/EventListener/TestAttributeListener.php b/...Injection/Fixtures/Bundles/DocumentListenerBundle/EventListener/TestAttributeListener.php
@@ -6,10 +6,10 @@
 
 use Doctrine\Bundle\MongoDBBundle\Attribute\AsDocumentListener;
 
-#[AsDocumentListener(event: 'prePersist', method: 'onPrePersist', lazy: true, connection: 'test', priority: 10)]
+#[AsDocumentListener(event: 'prePersist', connection: 'test', priority: 10)]
 class TestAttributeListener
 {
-    public function onPrePersist(): void
+    public function prePersist(): void
     {
     }
 }