Merge pull request #480 from greg0ire/finalize

Make final classes that can be
doctrine · Dec 3, 2024 · b2b9bfa · b2b9bfa
2 parents be1bc35 + 4530215
commit b2b9bfa
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 3 deletions.
diff --git a/UPGRADE.md b/UPGRADE.md
@@ -1,6 +1,11 @@
 UPGRADE to 4.0
 ==============
 
+## Final classes
+
+Some classes have been marked as `final` because they are not supposed to be
+extended. Consider using composition instead of inheritance.
+
 ## Mandatory ManagerRegistry argument
 
 It is now mandatory to pass a `ManagerRegistry` instance to the constructor of

diff --git a/src/Command/LoadDataFixturesDoctrineCommand.php b/src/Command/LoadDataFixturesDoctrineCommand.php
@@ -25,7 +25,7 @@
 /**
  * Load data fixtures from bundles.
  */
-class LoadDataFixturesDoctrineCommand extends DoctrineCommand
+final class LoadDataFixturesDoctrineCommand extends DoctrineCommand
 {
     /** @param PurgerFactory[] $purgerFactories */
     public function __construct(

diff --git a/src/DependencyInjection/DoctrineFixturesExtension.php b/src/DependencyInjection/DoctrineFixturesExtension.php
@@ -13,7 +13,7 @@
 
 use function dirname;
 
-class DoctrineFixturesExtension extends Extension
+final class DoctrineFixturesExtension extends Extension
 {
     /**
      * {@inheritDoc}

diff --git a/src/DoctrineFixturesBundle.php b/src/DoctrineFixturesBundle.php
@@ -11,7 +11,7 @@
 
 use function dirname;
 
-class DoctrineFixturesBundle extends Bundle
+final class DoctrineFixturesBundle extends Bundle
 {
     public function build(ContainerBuilder $container): void
     {