Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow Symfony 5.0 #975

Merged
merged 1 commit into from
May 28, 2019
Merged

Allow Symfony 5.0 #975

merged 1 commit into from
May 28, 2019

Conversation

nicolas-grekas
Copy link
Member

Same as two years ago: this is required to unlock our CI and will help ensure Doctrine is compatible from day 1.

@alcaeus
Copy link
Member

alcaeus commented May 28, 2019

Note: due to doctrine/DoctrineCacheBundle#156 we still need to remove the dependency on cache-bundle to make the whole stack work on Symfony 5. Please let me know what we can do to make sure the Symfony Test Suite runs in the meantime.

edit: never mind, didn't see the associated PR in time.

@alcaeus alcaeus added this to the 1.12.0 milestone May 28, 2019
@alcaeus alcaeus self-assigned this May 28, 2019
@alcaeus alcaeus merged commit eb068c2 into doctrine:master May 28, 2019
@nicolas-grekas nicolas-grekas deleted the sf5 branch May 28, 2019 15:11
nicolas-grekas added a commit to nicolas-grekas/symfony that referenced this pull request May 28, 2019
This PR was merged into the 5.0-dev branch.

Discussion
----------

Bump Symfony 5.0 to PHP 7.2

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

Not ready yet.

7.2 because it has all we need for the next two years (7.3 doesn't provide anything we absolutely need, and 7.4 is not even released so cannot be considered yet.)

7.2.9 because of https://tracker.debian.org/pkg/php7.2

Needs:
- [x] symfony/security-acl#48
- [x] doctrine/orm#7723
- [x] doctrine/DoctrineBundle#975
- [x] doctrine/DoctrineCacheBundle#158
- [x] symfony#31657

Commits
-------

d94d9d7 Bump Symfony 5.0 to PHP 7.2
@alcaeus alcaeus modified the milestones: 1.12.0, 2.0.0 Jun 11, 2019
@jderusse jderusse mentioned this pull request May 19, 2021
joshtrichards pushed a commit to joshtrichards/symfony-finder that referenced this pull request Apr 26, 2024
This PR was merged into the 5.0-dev branch.

Discussion
----------

Bump Symfony 5.0 to PHP 7.2

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

Not ready yet.

7.2 because it has all we need for the next two years (7.3 doesn't provide anything we absolutely need, and 7.4 is not even released so cannot be considered yet.)

7.2.9 because of https://tracker.debian.org/pkg/php7.2

Needs:
- [x] symfony/security-acl#48
- [x] doctrine/orm#7723
- [x] doctrine/DoctrineBundle#975
- [x] doctrine/DoctrineCacheBundle#158
- [x] symfony/symfony#31657

Commits
-------

72bd47e Bump Symfony 5.0 to PHP 7.2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants