-
-
Notifications
You must be signed in to change notification settings - Fork 454
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow Symfony 5.0 #975
Merged
Merged
Allow Symfony 5.0 #975
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alcaeus
approved these changes
May 28, 2019
Note: due to doctrine/DoctrineCacheBundle#156 we still need to remove the dependency on cache-bundle to make the whole stack work on Symfony 5. Please let me know what we can do to make sure the Symfony Test Suite runs in the meantime. edit: never mind, didn't see the associated PR in time. |
This was referenced May 28, 2019
5 tasks
nicolas-grekas
added a commit
to nicolas-grekas/symfony
that referenced
this pull request
May 28, 2019
This PR was merged into the 5.0-dev branch. Discussion ---------- Bump Symfony 5.0 to PHP 7.2 | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - Not ready yet. 7.2 because it has all we need for the next two years (7.3 doesn't provide anything we absolutely need, and 7.4 is not even released so cannot be considered yet.) 7.2.9 because of https://tracker.debian.org/pkg/php7.2 Needs: - [x] symfony/security-acl#48 - [x] doctrine/orm#7723 - [x] doctrine/DoctrineBundle#975 - [x] doctrine/DoctrineCacheBundle#158 - [x] symfony#31657 Commits ------- d94d9d7 Bump Symfony 5.0 to PHP 7.2
Merged
joshtrichards
pushed a commit
to joshtrichards/symfony-finder
that referenced
this pull request
Apr 26, 2024
This PR was merged into the 5.0-dev branch. Discussion ---------- Bump Symfony 5.0 to PHP 7.2 | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - Not ready yet. 7.2 because it has all we need for the next two years (7.3 doesn't provide anything we absolutely need, and 7.4 is not even released so cannot be considered yet.) 7.2.9 because of https://tracker.debian.org/pkg/php7.2 Needs: - [x] symfony/security-acl#48 - [x] doctrine/orm#7723 - [x] doctrine/DoctrineBundle#975 - [x] doctrine/DoctrineCacheBundle#158 - [x] symfony/symfony#31657 Commits ------- 72bd47e Bump Symfony 5.0 to PHP 7.2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Same as two years ago: this is required to unlock our CI and will help ensure Doctrine is compatible from day 1.