Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Webprofiler] Improve SQL explain table display #681

Merged
merged 1 commit into from
Jul 28, 2017

Conversation

mimol91
Copy link
Contributor

@mimol91 mimol91 commented Jul 28, 2017

Table which is shown in Weprofiler is not clean while values in sql explain table are long.
This PR adds horizontal scroll for long tables.

Related PR in Symfony Webprofiler: symfony/symfony#23706
(It does not cause any backward compatibility problems)

Before:
before

After:
after

@mikeSimonson
Copy link
Contributor

Thanks for the the PR, I am going to merge this right away but I will wait for @stof advice on the second before to merge it.

@mikeSimonson mikeSimonson merged commit 629d2a8 into doctrine:master Jul 28, 2017
fabpot added a commit to symfony/symfony that referenced this pull request Aug 1, 2017
This PR was merged into the 3.4 branch.

Discussion
----------

[Webprofiler] Improve sql explain table display

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | yes?
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

Table which is shown in Weprofiler is not clean while values in sql explain table are long.
This PR adds horizontal scroll for long tables.

**Related PR in Doctrine bundle:** doctrine/DoctrineBundle#681
_(It does not cause any backward compatibility problems)_

**Before:**
![before](https://user-images.githubusercontent.com/2659069/28733410-0ca76826-73ed-11e7-9fea-b3c49a5442ed.gif)

**After:**
![after](https://user-images.githubusercontent.com/2659069/28733415-11b76ae6-73ed-11e7-9e1a-ace661a1cd44.gif)

Commits
-------

2769550 improve sql explain table display
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants