Require PHP 7.1 #668
Merged
Require PHP 7.1 #668
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikeSimonson
approved these changes
May 31, 2017
|
We're actually going to require php 7.1, so I'd suggest to already do it here |
Ocramius
previously requested changes
May 31, 2017
.travis.yml
Outdated
| @@ -7,20 +7,15 @@ cache: | |||
| - $HOME/.composer/cache | |||
|
|
|||
| php: | |||
| - 5.5 | |||
| - 5.6 | |||
| - 7.0 | |||
There was a problem hiding this comment.
We should drop this too, as per @lcobucci's review
alcaeus
force-pushed
the
update-dependencies
branch
from
43d4f91 to
9f9360c
Compare
lcobucci
approved these changes
Jun 1, 2017
|
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As with ORM itself, the bundle will require PHP 7 in the future. Older Symfony versions may be removed in a separate pull request. I haven't made the effort to use the
::classconstant and short array syntax throughout, I'll leave that for a separate pull request.