Add aliases to help autowiring #640
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolas-grekas
force-pushed
the
autow-alias
branch
2 times, most recently
from
fb1c2e9 to
0ce61a3
Compare
stof
approved these changes
Mar 22, 2017
| @@ -126,6 +126,7 @@ protected function dbalLoad(array $config, ContainerBuilder $container) | |||
|
|
|||
| $container->setAlias('database_connection', sprintf('doctrine.dbal.%s_connection', $this->defaultConnection)); | |||
| $container->setAlias('doctrine.dbal.event_manager', new Alias(sprintf('doctrine.dbal.%s_connection.event_manager', $this->defaultConnection), false)); | |||
| $container->setAlias('Doctrine\DBAL\Driver\Connection', new Alias('database_connection', false)); | |||
There was a problem hiding this comment.
I suggest putting this directly in dbal.xml, as it does not need to be dynamic based on the configuration
| @@ -373,6 +374,8 @@ protected function ormLoad(array $config, ContainerBuilder $container) | |||
| } | |||
|
|
|||
| $container->setAlias('doctrine.orm.entity_manager', sprintf('doctrine.orm.%s_entity_manager', $config['default_entity_manager'])); | |||
| $container->setAlias('Doctrine\ORM\EntityManagerInterface', new Alias('doctrine.orm.entity_manager', false)); | |||
| $container->setAlias('Doctrine\Common\Persistence\ObjectManager', new Alias('doctrine.orm.entity_manager', false)); | |||
nicolas-grekas
force-pushed
the
autow-alias
branch
3 times, most recently
from
7842250 to
38748da
Compare
nicolas-grekas
commented
Mar 26, 2017
| @@ -116,36 +116,6 @@ public function testGetUnknownEntityManager() | |||
| $registry->getManager('default'); | |||
| } | |||
|
|
|||
| public function testResetDefaultEntityManager() | |||
There was a problem hiding this comment.
these two tests rely on deprecated behavior, and do not test things in the bundle, be behavior in the doctrine bridge. Since it's not the responsibility of the bundle to test the bridge, they can and should be removed.
|
Remaining failure will be fixed once symfony/symfony#22164 is merged up to 2.8. |
nicolas-grekas
force-pushed
the
autow-alias
branch
from
38748da to
e421a83
Compare
|
Thank you @nicolas-grekas. |
fabpot
added a commit
that referenced
this pull request
Mar 26, 2017
This PR was merged into the 1.6.x-dev branch. Discussion ---------- Add aliases to help autowiring Commits ------- e421a83 Add aliases to help autowiring
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.