Register the PropertyInfo extractor from the Symfony Bridge #502
Conversation
| } | ||
|
|
||
| foreach ($config['entity_managers'] as $name => $entityManager) { | ||
| $this->loadPropertyInfoExtractor($name, $container); |
There was a problem hiding this comment.
don't loop a second time. Do it in loadOrmEntityManager
|
@stof PR updated |
|
Is it possible to merge this PR? |
|
👍 |
| * @param string $entityManagerName | ||
| * @param ContainerBuilder $container | ||
| */ | ||
| protected function loadPropertyInfoExtractor($entityManagerName, ContainerBuilder $container) |
|
@xabbuh's comments fixed. |
| "doctrine/orm": "The Doctrine ORM integration is optional in the bundle." | ||
| "symfony/web-profiler-bundle": "To use the data collector.", | ||
| "doctrine/orm": "The Doctrine ORM integration is optional in the bundle.", | ||
| "symfony/property-info": "To use the PropertyInfo integration." |
There was a problem hiding this comment.
I'm not sure this suggestion makes sense. Saying "install this component to use this component" looks weird. People wanting to use PropertyInfo will install it. And DoctrineBundle does not provide any feature based on the PropertyInfo which would let people wonder whether they want to use PropertyInfo. It only provides the inner parts for PropertyInfo.
|
Status? |
|
@kimhemsoe finished. Can be merged (according to me). |
|
Sorry to insist, but is it possible to merge this one? |
|
@dunglas Thanks |
|
@mikeSimonson thank you very much for the review and the merge! |
Allow to extract metadata about properties coming from Doctrine using the new PropertyInfo component of Symfony 2.8.