Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix move of CodeExtension #1725

Merged
merged 1 commit into from
Nov 11, 2023
Merged

Conversation

chr-hertel
Copy link
Contributor

not sure if that's the right way to handle this and which target branch.

@chr-hertel chr-hertel force-pushed the fix-code-extension-v7 branch from 942f702 to a548ed9 Compare November 10, 2023 22:09
@chr-hertel chr-hertel changed the base branch from 2.11.x to 2.10.x November 10, 2023 22:09
@ostrolucky
Copy link
Member

What problem are you solving? Is there an issue somewhere you could reference?

@dmaicher
Copy link
Contributor

solving this build fail I guess?

https://github.com/doctrine/DoctrineBundle/actions/runs/6829814285/job/18576668292?pr=1721

Copy link
Member

@derrabus derrabus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. Just some minor nit-picking.

Tests/ProfilerTest.php Outdated Show resolved Hide resolved
@chr-hertel chr-hertel force-pushed the fix-code-extension-v7 branch from a548ed9 to c799161 Compare November 11, 2023 09:29
@chr-hertel
Copy link
Contributor Author

sorry, yes, i had the issue in the pipeline of #1721 with Symfony 7.

caused by symfony/symfony#52483

@derrabus derrabus merged commit 1d2a578 into doctrine:2.10.x Nov 11, 2023
13 checks passed
@derrabus
Copy link
Member

Thank you!

derrabus added a commit that referenced this pull request Nov 11, 2023
* 2.10.x:
  fix move of CodeExtension (#1725)
@chr-hertel chr-hertel deleted the fix-code-extension-v7 branch November 11, 2023 09:50
@dmaicher dmaicher added this to the 2.11.0 milestone Nov 11, 2023
@dmaicher dmaicher removed the Feature label Nov 11, 2023
@dmaicher dmaicher removed this from the 2.11.0 milestone Nov 11, 2023
@derrabus derrabus added this to the 2.10.3 milestone Nov 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants