Compatibility with ORM 3 #1722
Compatibility with ORM 3 #1722
Conversation
| use function sprintf; | ||
| use function trait_exists; | ||
|
|
||
| if (trait_exists(LazyGhostTrait::class)) { | ||
| if (trait_exists(LazyGhostTrait::class) && property_exists(EntityRepository::class, '_entityName')) { |
There was a problem hiding this comment.
This basically opts us out of the new LazyServiceEntityRepository for ORM 3. I need a little help to get this to work, @nicolas-grekas.
There was a problem hiding this comment.
Ideally, we would get rid of LazyServiceEntityRepository: I introduced it to keep BC with existing protected properties on EntityRepository. But since those are private in 3.0, we should now be able to deal with lazyness by decorating public/protected methods. As a reminder, the purpose of the lazy proxy is to move the $manager = $registry->getManagerForClass($entityClass); call out of the construction step.
There was a problem hiding this comment.
This PR still support ORM 2.x though.
There was a problem hiding this comment.
I've pushed a version with a proxy for EntityRepository.
derrabus
force-pushed
the
feature/orm-3
branch
6 times, most recently
from
07f448a to
08aee56
Compare
|
Ugh, Psalm 4 is a mess. :-( |
derrabus
force-pushed
the
feature/orm-3
branch
from
08aee56 to
93b0a66
Compare
derrabus
force-pushed
the
feature/orm-3
branch
from
93b0a66 to
a588397
Compare
| $configuration = new Configuration(true); | ||
| $configuration->getConfigTreeBuilder(); | ||
|
|
||
| $this->assertFalse(class_exists('Doctrine\Common\Proxy\AbstractProxyFactory', false)); |
There was a problem hiding this comment.
This is a very old test and I'm not sure if we still need it. I cannot make it pass anymore because I need to feature-check if we can allow not enabling the lazy ghost implementation.
|
Can we move some of those psalm suppressions inline? We put it to config file only when that doesn't work. |
derrabus
force-pushed
the
feature/orm-3
branch
from
a588397 to
264a7f4
Compare
Done for the |
derrabus
force-pushed
the
feature/orm-3
branch
5 times, most recently
from
6fbd181 to
3e8ca45
Compare
| */ | ||
| class ServiceEntityRepository extends LazyServiceEntityRepository | ||
| { | ||
| if (property_exists(EntityRepository::class, '_entityName')) { |
There was a problem hiding this comment.
Oh boy, people were already complaining about previous logic being too difficult for SA tools to understand (#1677), now it's going to get worse. But I guess we can't do anything about it
There was a problem hiding this comment.
Not without breaking stuff, I'm afraid. It might be worth doing a 3.0 soon'ish.
derrabus
force-pushed
the
feature/orm-3
branch
from
3e8ca45 to
0c3005e
Compare
derrabus
force-pushed
the
feature/orm-3
branch
from
0c3005e to
97517d8
Compare
This PR adds compatibility with ORM 3. I'm not very proud of the code that I had to write and I'm open to ideas. 🙈
As a side effect, I'm deprecating not enabling the lazy ghost implementation, just as the ORM did. If the app did not specify which proxy implementation should be used, this is what the bundle decides:
If the app explicitly opts out of lazy ghosts despite having ORM 3 installed, the container won't compile.