Add Symfony 7 support #1692
Merged
Add Symfony 7 support #1692
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ostrolucky
force-pushed
the
symfony-7
branch
3 times, most recently
from
a22d139 to
2b7916e
Compare
stof
reviewed
Aug 22, 2023
nicolas-grekas
approved these changes
Aug 23, 2023
derrabus
approved these changes
Aug 23, 2023
stof
approved these changes
Aug 23, 2023
|
Could help fix the failing job: --- a/.github/workflows/continuous-integration.yml
+++ b/.github/workflows/continuous-integration.yml
@@ -39,7 +39,7 @@ jobs:
# Test LTS
- symfony-require: "5.4.*"
dependencies: "highest"
- php-version: "8.0"
+ php-version: "8.1"
|
|
@nicolas-grekas to me, this is a bug in Symfony if installing deps on PHP 8.0 with Symfony 5.4 brings incompatible dependencies between Symfony packages. |
|
I agree, but I'd wait for someone to be affected to have a closer look :) |
|
I think it's just because symfony/translation-contracts@9fca658 was still not tagged |
ostrolucky
force-pushed
the
symfony-7
branch
2 times, most recently
from
8efe508 to
6b78117
Compare
xabbuh
reviewed
Sep 4, 2023
xabbuh
approved these changes
Sep 4, 2023
SenseException
approved these changes
Sep 4, 2023
ostrolucky
force-pushed
the
symfony-7
branch
from
6b78117 to
2cc9f2b
Compare
derrabus
approved these changes
Sep 5, 2023
2 tasks
|
Thank you @ostrolucky |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was curious what needs to be done so far. Not much so far.
@nicolas-grekas Is that added Container type declaration (instead of ContainerInterface) in
\Symfony\Bridge\Doctrine\ManagerRegistrylegit?