Revert "Add PhpArrayAdapter to cache metadata" #1255
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #1196
Few issues popped up and looks like at least #1251 is not very solvable on our side, as PHPArray cache is not designed to be modified, which includes deleting it as well. #1249 is most likely tricky to solve as well.
This decision came from both me and @dmaicher. We need to rollback this fast, because it introduces deprecation of the option we suggested to remove. If we rollback it after lot of people removed their metadata cache configurations, they will experience regressed performance.
We can always reintroduce this thing later, with more bug-prove solution.