Document UOW reset introduced since 1.12.3/2.0.3 #1134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
greg0ire
reviewed
Feb 1, 2020
ostrolucky
force-pushed
the
document-uow-clear
branch
from
e12e28b to
df557cc
Compare
greg0ire
approved these changes
Feb 1, 2020
bendavies
reviewed
Feb 1, 2020
UPGRADE-1.12.md
Outdated
| { | ||
| $container->getDefinition('doctrine')->clearTag('kernel.reset'); | ||
| } | ||
| }, \Symfony\Component\DependencyInjection\Compiler\PassConfig::TYPE_BEFORE_OPTIMIZATION, 1); |
There was a problem hiding this comment.
might be good to point out that this priority is and must be higher than Symfony\Component\HttpKernel\DependencyInjection\ResettableServicePass
There was a problem hiding this comment.
How do you suggest to do that?
bendavies
reviewed
Feb 1, 2020
ostrolucky
force-pushed
the
document-uow-clear
branch
from
df557cc to
26228df
Compare
Co-Authored-By: Grégoire Paris <[email protected]>
ostrolucky
force-pushed
the
document-uow-clear
branch
from
26228df to
3c3cc0f
Compare
alcaeus
approved these changes
Feb 4, 2020
|
Thanks @ostrolucky! |
|
Thanks ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1112