Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix well known schema filter blacklist tables #1100

Merged
merged 2 commits into from
Dec 18, 2019
Merged

Fix well known schema filter blacklist tables #1100

merged 2 commits into from
Dec 18, 2019

Conversation

bendavies
Copy link
Contributor

These tables were backwards.

@bendavies bendavies force-pushed the fix-well-known-schema-filter-blacklist-tables branch from 7d463df to 2d43a8e Compare December 18, 2019 10:56
@bendavies bendavies changed the title reverse backwards tables fix well known schema filter blacklist tables Dec 18, 2019
@alcaeus alcaeus self-assigned this Dec 18, 2019
@alcaeus alcaeus added the Bug label Dec 18, 2019
@alcaeus alcaeus added this to the 1.12.3 milestone Dec 18, 2019
@alcaeus
Copy link
Member

alcaeus commented Dec 18, 2019

@bendavies can you please take a look at the failing tests? Thanks!

@bendavies bendavies force-pushed the fix-well-known-schema-filter-blacklist-tables branch from 2d43a8e to 0351ce0 Compare December 18, 2019 11:02
@bendavies
Copy link
Contributor Author

@alcaeus done. it would be better if the tests tested the services one by one, which would have caught this bug, but there we go.

@alcaeus
Copy link
Member

alcaeus commented Dec 18, 2019

@alcaeus done. it would be better if the tests tested the services one by one, which would have caught this bug, but there we go.

Absolutely - do you want to make the change?

@bendavies
Copy link
Contributor Author

sure

@bendavies
Copy link
Contributor Author

@alcaeus done

@bendavies bendavies force-pushed the fix-well-known-schema-filter-blacklist-tables branch from e14569c to 4cfbe9b Compare December 18, 2019 11:20
@alcaeus alcaeus merged commit 91287f5 into doctrine:1.12.x Dec 18, 2019
@alcaeus
Copy link
Member

alcaeus commented Dec 18, 2019

Thanks @bendavies!

@alcaeus alcaeus changed the title fix well known schema filter blacklist tables Fix well known schema filter blacklist tables Dec 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stof stof stof approved these changes

@alcaeus alcaeus alcaeus approved these changes

@nicolas-grekas nicolas-grekas nicolas-grekas approved these changes

Assignees

@alcaeus alcaeus

Labels
Bug
Projects
None yet
Milestone
1.12.3
Development

Successfully merging this pull request may close these issues.
4 participants
@bendavies @alcaeus @nicolas-grekas @stof