Deprecated alias on DI Extension #1079
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxhelias
force-pushed
the
deprecated-alias-bis
branch
from
20a36bf to
728f74d
Compare
|
@stof Can you tell me if it's ok like that ? |
alcaeus
requested changes
Nov 28, 2019
maxhelias
force-pushed
the
deprecated-alias-bis
branch
from
728f74d to
87b74f3
Compare
alcaeus
approved these changes
Nov 28, 2019
|
Thanks @maxhelias! |
|
@alcaeus I suggest making a release for that, to avoid getting lots of bug reports for that from people using stable releases. What do you think ? |
|
Done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix issue #1067