-
-
Notifications
You must be signed in to change notification settings - Fork 455
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update .travis.yml #1024
Update .travis.yml #1024
Conversation
removed PHP-7.4 from `.travis.yml` allow_failures to make it compatible with PHP 7.4. See #1023
Hi! If we no longer allow 7.4 to fail, we also need to fix the failure described here: https://travis-ci.org/doctrine/DoctrineBundle/jobs/591925826 |
This problem is related to Twig, not Doctrine. So, this PR can be merged temporarily. |
It really shouldn't IMO. If we merge it, builds that were previously green will become red for no good reason. If something has to be done temporarily, it's listing that 7.4 job as part of |
What about using PHP 7.4 for the build that uses not yet released dependencies versions? That should work as Twig already has a patch for this just without a stable release yet, shouldn't it? |
I think it would make a lot of sense! @nimah79 here is what I think @xabbuh is talking about: Lines 49 to 55 in af8ac79
|
@greg0ire I've just released Twig 2.12 which should unlock this PR. |
And tests are green now! |
Thank you @fabpot 👍 |
Thanks @fabpot! Merged! |
I think I merged a bit too fast… maybe we should require the new version? If yes, see #1025 |
removed PHP-7.4 from
.travis.yml
allow_failures to make it compatible with PHP 7.4.See #1023