Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update .travis.yml #1024

Merged
merged 1 commit into from
Oct 6, 2019
Merged

Update .travis.yml #1024

merged 1 commit into from
Oct 6, 2019

Conversation

Klizzy
Copy link
Contributor

@Klizzy Klizzy commented Oct 1, 2019

removed PHP-7.4 from .travis.yml allow_failures to make it compatible with PHP 7.4.
See #1023

removed PHP-7.4 from `.travis.yml` allow_failures to make it compatible with PHP 7.4.
See #1023
@greg0ire
Copy link
Member

greg0ire commented Oct 1, 2019

Hi! If we no longer allow 7.4 to fail, we also need to fix the failure described here: https://travis-ci.org/doctrine/DoctrineBundle/jobs/591925826

@nimah79
Copy link

nimah79 commented Oct 3, 2019

This problem is related to Twig, not Doctrine. So, this PR can be merged temporarily.

@greg0ire
Copy link
Member

greg0ire commented Oct 3, 2019

It really shouldn't IMO. If we merge it, builds that were previously green will become red for no good reason. If something has to be done temporarily, it's listing that 7.4 job as part of allowed_failures, and that's what we already do.

@xabbuh
Copy link
Member

xabbuh commented Oct 4, 2019

What about using PHP 7.4 for the build that uses not yet released dependencies versions? That should work as Twig already has a patch for this just without a stable release yet, shouldn't it?

@greg0ire
Copy link
Member

greg0ire commented Oct 4, 2019

I think it would make a lot of sense!

@nimah79 here is what I think @xabbuh is talking about:

# Test against latest Symfony 4.4 dev
- php: 7.3
env: SYMFONY_VERSION="4.4.*@dev" SYMFONY_DEPRECATIONS_HELPER=1
install:
- composer config minimum-stability dev
- composer require --dev "symfony/messenger:4.4.*@dev" --no-update
- travis_retry composer update -n --prefer-dist

@fabpot
Copy link
Member

fabpot commented Oct 5, 2019

@greg0ire I've just released Twig 2.12 which should unlock this PR.

@fabpot
Copy link
Member

fabpot commented Oct 5, 2019

And tests are green now!

@SenseException
Copy link
Member

Thank you @fabpot 👍

@greg0ire greg0ire merged commit 9df9ea4 into doctrine:1.12.x Oct 6, 2019
@greg0ire
Copy link
Member

greg0ire commented Oct 6, 2019

Thanks @fabpot! Merged!

@greg0ire
Copy link
Member

greg0ire commented Oct 6, 2019

I think I merged a bit too fast… maybe we should require the new version? If yes, see #1025

@alcaeus alcaeus modified the milestones: 1.11.3, 1.12.0 Oct 8, 2019
@alcaeus alcaeus self-assigned this Oct 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants