Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get real table name on translation insert #2637

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

asaintvanne
Copy link

Get table name with schema as it's done in Doctrine on translation part.

Get table name with schema as it's done in Doctrine
@asaintvanne asaintvanne changed the title Update ORM.php Get real table name on translation insert Jun 27, 2023
@codecov-commenter
Copy link

codecov-commenter commented Jun 27, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.24%. Comparing base (95bc3c8) to head (0b1de14).
Report is 139 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2637   +/-   ##
=======================================
  Coverage   79.23%   79.24%           
=======================================
  Files         161      161           
  Lines        8414     8416    +2     
=======================================
+ Hits         6667     6669    +2     
  Misses       1747     1747           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@phansys
Copy link
Collaborator

phansys commented Jun 27, 2023

Thanks @asaintvanne!
Is this a fix? Please, add a test covering this change and a note in the corresponding section of the CHANGELOG.md file.

Copy link

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added Stale and removed Stale labels Dec 24, 2023
Copy link

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants