Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Eslint fixes for v4x #989

Merged
merged 13 commits into from
Dec 30, 2019
Merged

Eslint fixes for v4x #989

merged 13 commits into from
Dec 30, 2019

Conversation

giulioambrogi
Copy link
Contributor

@giulioambrogi giulioambrogi commented Dec 27, 2019 •
edited by anikethsaha
Loading

Summary
Fix #987

Fulfilled requirements

  • Npm script fix
  • .eslintrc updated as per requirements
  • Lint Errors fix
  • Lint Warning fix
  • Add the linting to travis

Other information:
I've added "mocha": true to the env object in .eslintsrc to cover the tests. And removed the hard-coded /* eslint-env node, chai, mocha */ I've found in a couple of spec files.

@giulioambrogi giulioambrogi mentioned this pull request Dec 27, 2019
Closed
5 tasks
@anikethsaha
Copy link
Member

Thanks for the PR.

I've added "mocha": true to the env object in .eslintsrc to cover the tests. And removed the hard-coded /* eslint-env node, chai, mocha */ I've found in a couple of spec files.

We will migrate to jest so you can make it jest

@anikethsaha anikethsaha added this to the 4.x milestone Dec 27, 2019
@anikethsaha
Copy link
Member

anikethsaha commented Dec 27, 2019 •
edited
Loading

Cool,
I will review it locally against my e2e testing branch to see if anything is breaking or not as there were some changes with if conditions regarding null and undefined. I am pretty sure there won't be any changes to the executions and behavior but still want to make it sure once.

@giulioambrogi
Copy link
Contributor Author

some changes with if conditions regarding null and undefined.

Re the null/undefined changes I was looking for some unit tests to cover that but couldn't find any.
I'm very new to the repo so I don't know whether this is on purpose or not, e.g. you prefer having more integration tests than unit tests. Any idea?

@anikethsaha
Copy link
Member

We don't have any tests as of now.
I am working on e2e tests here #986
we need to increase test coverage in order to get the confidence of merging PRs.

@anikethsaha
Copy link
Member

@giulioambrogi could you resolve the conflicts

@giulioambrogi
Merge branch 'develop' into eslint-fixes-for-v4x and fix conflicts
8bc2964 
# Conflicts:
#	src/core/render/tpl.js
#	src/core/util/core.js
@giulioambrogi
Copy link
Contributor Author

@giulioambrogi could you resolve the conflicts

Done

@anikethsaha
Copy link
Member

@giulioambrogi could you resolve the conflicts

Done

Cool 👍

anikethsaha
anikethsaha approved these changes Dec 29, 2019
View reviewed changes
Copy link
Member

@anikethsaha anikethsaha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@anikethsaha anikethsaha merged commit db97a1d into docsifyjs:develop Dec 30, 2019
@anikethsaha anikethsaha mentioned this pull request Feb 20, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anikethsaha anikethsaha anikethsaha approved these changes

@trusktr trusktr Awaiting requested review from trusktr

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
4.x
Development

Successfully merging this pull request may close these issues.

Eslint fixes for the project
2 participants
@giulioambrogi @anikethsaha