Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allows relative path, fixed #590 #714

Merged
merged 2 commits into from
Apr 7, 2019

Conversation

sansnom
Copy link
Contributor

@sansnom sansnom commented Dec 6, 2018

Hello,

It's the same PR as #593 thanks to @NoCLin which allows relative path (fix #590). But I've added an option relativePath to enable it (like proposed in #657). By default it's disabled so it's backward compatible: no breaking changes. :)

I've tried to add some documentation, I hope it's clear enough.

Please makes sure these boxes are checked before submitting your PR, thank you!

  • Make sure you are merging your commits to master branch.
  • Add some descriptions and refer relative issues for you PR.
  • DO NOT include files inside lib directory.

@timaschew
Copy link
Member

Any plans to merge this PR (before 5.0)?

@sansnom
Copy link
Contributor Author

sansnom commented Jan 30, 2019

@timaschew any plan to merge this one ? :)

@timaschew
Copy link
Member

@sansnom I've created today a PR (not merged yet) providing a test environment in order to verify that we don't introduce new bugs when changing anything. Would be nice if we can have some tests for this feature as well. If you git rebase -i origin/provide-tests you should have the test setup available.

docs/configuration.md Show resolved Hide resolved
@timaschew timaschew mentioned this pull request Feb 5, 2019
3 tasks
docs/configuration.md Show resolved Hide resolved
src/core/router/history/base.js Outdated Show resolved Hide resolved
docs/configuration.md Show resolved Hide resolved
@sansnom
Copy link
Contributor Author

sansnom commented Mar 28, 2019

Anyone to recheck and merge this ? :) I've added some unit test.

Thanks !

cc @QingWei-Li @timaschew

@timaschew
Copy link
Member

@sansnom thanks!

I will do it when #603 will be resolved.

@sansnom
Copy link
Contributor Author

sansnom commented Apr 3, 2019

@sansnom thanks!

I will do it when #603 will be resolved.

@timaschew Glad to see #603 has been resolved and the project can continue. :)

@timaschew
Copy link
Member

@sansnom sorry for the delay. I will merge it this weekend.

@timaschew timaschew merged commit bba44fb into docsifyjs:master Apr 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants