-
-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: allows relative path, fixed #590 #714
Conversation
Any plans to merge this PR (before 5.0)? |
@timaschew any plan to merge this one ? :) |
@sansnom I've created today a PR (not merged yet) providing a test environment in order to verify that we don't introduce new bugs when changing anything. Would be nice if we can have some tests for this feature as well. If you |
Anyone to recheck and merge this ? :) I've added some unit test. Thanks ! |
@timaschew Glad to see #603 has been resolved and the project can continue. :) |
@sansnom sorry for the delay. I will merge it this weekend. |
Hello,
It's the same PR as #593 thanks to @NoCLin which allows relative path (fix #590). But I've added an option relativePath to enable it (like proposed in #657). By default it's disabled so it's backward compatible: no breaking changes. :)
I've tried to add some documentation, I hope it's clear enough.
Please makes sure these boxes are checked before submitting your PR, thank you!
master
branch.lib
directory.