Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: customising cover page background colour not working #669

Merged
merged 1 commit into from
Oct 31, 2018

Conversation

cheng-kang
Copy link
Contributor

Closes #666

Issue

[email protected] renders image without <p> wrapper, which is different from [email protected].

Solution

Updating match regex in _renderCover solves the problem.


Please makes sure these boxes are checked before submitting your PR, thank you!

  • Make sure you are merging your commits to master branch.
  • Add some descriptions and refer relative issues for you PR.
  • DO NOT include files inside lib directory.

@QingWei-Li QingWei-Li merged commit 2edf47e into master Oct 31, 2018
@QingWei-Li
Copy link
Member

Good job.

FIY please use angular commit conventions.

@cheng-kang
Copy link
Contributor Author

@QingWei-Li thanks, will do

@cheng-kang cheng-kang deleted the fix/666 branch October 31, 2018 23:28
@xunilog
Copy link

xunilog commented Mar 22, 2019

@cheng-kang . Issue still present in 4.9.1, cannot see this fix over there.

@danieldilly
Copy link

I just followed the Quick Start guide on the Official Website and I'm experiencing this issue. I can't change the background color or the background image.

@anikethsaha
Copy link
Member

submit a fresh issue, with reproducible data. we can discuss there.

Thanks for pointing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants