-
-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Update test environments and lint configuration #1736
Merged
Merged
Changes from all commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
e58b74d
Update test environments and lint configuration
jhildenbiddle 27c6592
Merge branch 'develop' into update-test-env
jhildenbiddle a98ed8f
Update Github CI
jhildenbiddle ac7652f
Fix ESLint errors
jhildenbiddle f7c93c4
Update test.yml
jhildenbiddle 111841a
Update test.yml
jhildenbiddle a547729
Update test artifact config
jhildenbiddle 6e74d8a
Update test.yml
jhildenbiddle 33488c3
Update test.yml
jhildenbiddle a0415af
Update test.yml
jhildenbiddle 2bc620b
Update test.yml
jhildenbiddle 5dea79f
Update test.yml
jhildenbiddle a8ef929
Update test.yml
jhildenbiddle 05c2c4b
Fix ESLint errors
jhildenbiddle 02cff2d
Update test.yml
jhildenbiddle 7d51edc
Update test.yml
jhildenbiddle File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,10 +1,9 @@ | ||
.git | ||
packages/docsify-server-renderer/build.js | ||
node_modules | ||
**/*.md | ||
build | ||
server.js | ||
docs | ||
lib | ||
node_modules | ||
packages/docsify-server-renderer/build.js | ||
server.js | ||
themes | ||
build | ||
docs/ | ||
**/*.md |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,10 +1,11 @@ | ||
*.log | ||
.DS_Store | ||
.idea | ||
__diff_output__ | ||
lib/ | ||
*.log | ||
_playwright-report | ||
_playwright-results | ||
lib | ||
node_modules | ||
themes/ | ||
themes | ||
|
||
# exceptions | ||
!.gitkeep |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,5 @@ | ||
.eslintignore | ||
.eslintrc | ||
.github/ | ||
.github | ||
.gitignore | ||
.travis.yml |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,4 @@ | ||
module.exports = { | ||
arrowParens: 'avoid', | ||
singleQuote: true, | ||
trailingComma: 'es5', | ||
}; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,4 @@ | ||
{ | ||
"editor.defaultFormatter": "esbenp.prettier-vscode" | ||
"editor.defaultFormatter": "esbenp.prettier-vscode", | ||
"cSpell.words": ["coverpage"] | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what is this used for?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is part of the upload-artifact action configuration. Entries in the
path
are zipped and made available for download after all jobs are completed. In this case:_playwright-results
contains screenshot diffs. We aren't using them yet, but I wanted to have everything ready to go if/when someone wants too._playwright-report
contains an HTML report of the Playwright set results.Screenshot diffs will only be available when one-or-more screenshot tests fail. The HTML report is generated every test run, but I'm going to update the action configuration to only store artifacts when a failure occurs. We don't need HTML reports filled with green check marks (as satisfying as they may be). :)
Currently, the HTML report is stored even when all tests pass, but I should switch this so
FYI: Artifacts can be downloaded on the bottom of an Action's detail page: