Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CONTRIBUTING.md #1532

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from
Open

Update CONTRIBUTING.md #1532

wants to merge 4 commits into from

Conversation

trusktr
Copy link
Member

@trusktr trusktr commented Mar 9, 2021

Summary

This is a small change to mention pull request templates in CONTRIBUTING.md, and to show what the new template look likes.

What kind of change does this PR introduce?

Docs

For any code change,

  • Related documentation has been updated if needed
  • Related tests have been updated or tests have been added

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

Related issue, if any:

Tested in the following browsers:

  • Chrome
  • Firefox
  • Safari
  • Edge
  • IE

@vercel
Copy link

vercel bot commented Mar 9, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/docsify-core/docsify-preview/5Y9HaWxFxACEz7ZM3P2uhuHmed5D
✅ Preview: https://docsify-preview-git-update-contributing-docsify-core.vercel.app

@trusktr
Copy link
Member Author

trusktr commented Mar 9, 2021

Hmm, it still feels a bit noisy. 🤔

@codesandbox-ci
Copy link

codesandbox-ci bot commented Mar 9, 2021

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 5dab7fa:

Sandbox Source
docsify-template Configuration

sy-records
sy-records previously approved these changes Mar 9, 2021
@sy-records
Copy link
Member

sy-records commented Mar 9, 2021

We can merge these two

What kind of change does this PR introduce? and Does this PR introduce a breaking change? (check one)

Can this be removed and a comment added to the Summary?

Related issue, if any:

Koooooo-7
Koooooo-7 previously approved these changes Mar 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants