Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Update helpers.md #1294

Merged
merged 3 commits into from
Jul 20, 2020
Merged

docs: Update helpers.md #1294

merged 3 commits into from
Jul 20, 2020

Conversation

docyx
Copy link
Contributor

@docyx docyx commented Jul 20, 2020

Summary

Modify Chinese in English docs.

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Docs
  • Build-related changes
  • Repo settings
  • Other, please describe:

If changing the UI of default theme, please provide the before/after screenshot:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)

You have tested in the following browsers: (Providing a detailed version will be better.)

  • Chrome
  • Firefox
  • Safari
  • Edge
  • IE

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature
  • Related documents have been updated
  • Related tests have been updated

To avoid wasting your time, it's best to open a feature request issue first and wait for approval before working on it.

@vercel
Copy link

vercel bot commented Jul 20, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/docsify-core/docsify-preview/5dueh5s7u
✅ Preview: https://docsify-preview-git-fork-docyx-patch-1.docsify-core.vercel.app

@codesandbox-ci
Copy link

codesandbox-ci bot commented Jul 20, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit bd1b718:

Sandbox Source
docsify-template Configuration

sy-records
sy-records previously approved these changes Jul 20, 2020
@docyx docyx closed this Jul 20, 2020
@sy-records
Copy link
Member

Why close?

@docyx
Copy link
Contributor Author

docyx commented Jul 20, 2020

@sy-records Because you approved it.

@sy-records
Copy link
Member

sy-records commented Jul 20, 2020

That’s just approval, not merge. Can you modify it in accordance with #1295 I modified it.

@vercel vercel bot temporarily deployed to Preview July 20, 2020 06:43 Inactive
@sy-records sy-records changed the title Remove racist example in docs/helpers.md docs: Update helpers.md Jul 20, 2020
Copy link
Member

@Koooooo-7 Koooooo-7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@sy-records
Copy link
Member

Thank you for your contribution.

@sy-records sy-records merged commit 13d4232 into docsifyjs:develop Jul 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants