Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: gitignore was ignoring folders in src… #1287

Merged
merged 2 commits into from
Jul 16, 2020
Merged

Conversation

trusktr
Copy link
Member

@trusktr trusktr commented Jul 16, 2020

…so VS Code search results or file fuzzy finder were not working, etc

Summary

.gitignore was ignoring stuff in the src folder. VS Code respects .gitignore, so this caused VS Code not to show me search results in files inside of the src/themes/ folder, and to not be able to open those files using the file palette (fuzzy finder).

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Docs
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

Other information:


  • DO NOT include files inside lib directory. (/lib is in gitignore, why do we need this check box?)

@vercel
Copy link

vercel bot commented Jul 16, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/docsify-core/docsify-preview/6k0o326rq
✅ Preview: https://docsify-preview-git-fix-gitignore.docsify-core.vercel.app

@codesandbox-ci
Copy link

codesandbox-ci bot commented Jul 16, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit e664a34:

Sandbox Source
docsify-template Configuration


---

* [ ] DO NOT include files inside `lib` directory.
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No reason to keep this, it is listed in gitignore.

@trusktr trusktr changed the title fix: gitignore was ignoring folders in src, so VS Code search results… fix: gitignore was ignoring folders in src… Jul 16, 2020
@trusktr trusktr added the semver-patch This needs a patch release label Jul 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver-patch This needs a patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants