Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify Chinese doc link #1151

Merged
merged 1 commit into from
Apr 28, 2020
Merged

Modify Chinese doc link #1151

merged 1 commit into from
Apr 28, 2020

Conversation

sy-records
Copy link
Member

Summary

Hello, @anikethsaha there are two index.html, did I forget to modify this file?

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Docs
  • Build-related changes
  • Other, please describe:

If changing the UI of default theme, please provide the before/after screenshot:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)

You have tested in the following browsers: (Providing a detailed version will be better.)

  • Chrome
  • Firefox
  • Safari
  • Edge
  • IE

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature
  • Related documents have been updated
  • Related tests have been updated

To avoid wasting your time, it's best to open a feature request issue first and wait for approval before working on it.

Other information:


  • DO NOT include files inside lib directory.

@anikethsaha
Copy link
Member

yes there are two, the one in the root is for local development. and docs/index.html is for the website/

@anikethsaha anikethsaha merged commit 0bbc02c into docsifyjs:develop Apr 28, 2020
@sy-records sy-records deleted the patch-1 branch April 28, 2020 04:49
@sy-records
Copy link
Member Author

As I said in gitter, does the use of Chinese documents need to wait for the next release?

@anikethsaha
Copy link
Member

yes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants