Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optional javascript #81

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

vespakoen
Copy link
Contributor

I wonder what you think about this...

This change allows one to not include the JavaScript types from this library but use the builtin / latest TypeScript ES5 types.

Of course, shimming will still have to be done manually when going this route.

At the moment I am using this: https://github.com/adobe-extension-tools/extendscript-es5-shim-ts
Which also includes type definitions of ES5, but those are copy / pasted from TypeScript a while ago, and I noticed that they have become a bit outdated and are missing some things.

The advantage of this approach is that the types are kept up to date by TypeScript, by default, we can still advise to use "noLib" and include the "JavaScript" types from this package (see updated README).

Try it out:

# create new folder
mkdir my-script
cd my-script

# install types-for-adobe
npm init -y
npm i github:vespakoen/types-for-adobe#optional-javascript

# create tsconfig.json
printf '{"compilerOptions":{"module":"none","lib": ["ES5"], "types": ["types-for-adobe/Illustrator/2015.3", "types-for-adobe/PlugPlugExternalObject"],}}' > tsconfig.json

# create index.ts and write typed code!
printf 'alert(String(app));\n' > index.ts

# compile typescript files
tsc

This is built on top of PR #80

@pravdomil pravdomil force-pushed the master branch 2 times, most recently from e98bb94 to 052bc32 Compare February 17, 2022 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant