update master #377
Merged
update master #377
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make minor fix in the CLI documentation to reflect this comment: webpack#1577 (comment)
Changed example to declare the plugin within `plugins` property.
Rewrite the main sections of the guide to synchronize it with the other core guides. Briefly mention the other utilities that don't require full on examples (details can be found via links). Closes #1258
OpenCollective's structure changed a bit. This address that and makes a few other notable changes: - add additional sponsors - allow to merge additional sponsors to existing sponsors - limit width of logos to 3 x height to disallow very wide logos - format money values with commas
Remove local type def from TypeScript snippet. The @types/node type definition module already declares `__dirname` type: https://git.io/v5Dr9
Add an example to demonstrate using hot module replacement with `webpack-dev-server`'s Node.js API instead of within a normal configuration file.
The article was missing references to `clean-webpack-plugin` in the `webpack.config.js` file and `package.json` files.
As a conclusion, I thought it would be a good idea to show case a high-level explanation of why it's called tree shaking. Once the user reads the guide and ends up with a high-level explanation the word tree shaking will stick to the user's head.
Suggest solutions to the problem right away seems to be a better approach. Use similar text as was used here: https://webpack.js.org/api/module-methods/#import-
Add more information about optimization bailouts. Attempt to transfer content from the blog post to the official docs. I want to follow up with a PR for better bailout reasons. The hope is that the reasons will match those listed in the table.
Clarify interactions between `libraryTarget` and `library`. The interactions between the two and how some of the sections were not well explained, in some cases were incorrect, misleading or missing information.
Add documentation about setting environment variables in CLI with `--env`. Link to webpack _CLI Environment_ section. Add additional usage to `--env` CLI docs.
`pre` loaders run at the beginning, `post` loaders run at the end.
|
有冲突。 @dear-lizhihua |
# Conflicts: # src/content/plugins/module-concatenation-plugin.md
|
@aladdin-add 解决了 |
aladdin-add
approved these changes
Oct 10, 2017
TyreeZhao
pushed a commit
to TyreeZhao/webpack.js.org
that referenced
this pull request
Oct 11, 2017
aladdin-add
pushed a commit
that referenced
this pull request
Oct 18, 2017
* translated ModuleConcatenationPlugin * formate * added spaces. * formate * code review * optimized * updated * updated * Update module-concatenation-plugin.md * updated /content/plugins/module-concatenation-plugin.md(#377) * improved 捆绑失败优化 => 捆绑失败的优化 * scope: 范围 => 作用域 * updated 模型 => 模块 捆绑=> 绑定 * trans review * Update module-concatenation-plugin.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.