Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cache-binary input to enable/disable caching binary to GHA cache backend #300

Merged
merged 2 commits into from
Feb 23, 2024

Conversation

crazy-max
Copy link
Member

@crazy-max crazy-max commented Feb 23, 2024

follow-up docker/actions-toolkit#257

@nicks It should mitigate your issue related to #293. We could also save cache in post action step like you did in docker/actions-toolkit#241. I can carry this if you want 🙏

@crazy-max crazy-max marked this pull request as ready for review February 23, 2024 10:03
Copy link
Contributor

@nicks nicks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@nicks
Copy link
Contributor

nicks commented Feb 23, 2024

i closed the other pr -- it might be still worth doing at some point, but less urgent now that we figured out the real issue

@crazy-max crazy-max merged commit 0d103c3 into docker:master Feb 23, 2024
43 checks passed
@crazy-max crazy-max deleted the cache-binary branch February 23, 2024 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants