This repository has been archived by the owner on Nov 29, 2023. It is now read-only.
Improve error message if the user is not logged in #202
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
Improved the error message when not logged in. The main problem is that the suggestion to "use the Docker Login command" will not work easily if
An advanced user can figure this out by using a PAT, but the simplest thing for most users is to log in via the Docker Desktop UI which will handle the 2FA/SSO for you transparently.
- How I did it
I listed the options in the message, leaving the simplest one for new users at the end.
- How to verify it
Before if you
docker logout
:After this change if you
docker logout
:- Description for the changelog
- A picture of a cute animal (not mandatory)