Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Volumes API #34

Open
bwateratmsft opened this issue Sep 22, 2020 · 4 comments
Open

Volumes API #34

bwateratmsft opened this issue Sep 22, 2020 · 4 comments

Comments

@bwateratmsft
Copy link

The new Docker CLI recently added volumes support (at least in ACI contexts). Can this SDK also add support for that? I assume it would mean new protos for volumes.
@bwateratmsft bwateratmsft mentioned this issue Sep 22, 2020
Closed
@gtardif
Copy link
Collaborator

gtardif commented Sep 23, 2020

Yes it's in our plans, a Volume API for ACI contexts should arrive soon here

@gtardif
Copy link
Collaborator

gtardif commented Sep 23, 2020

cc @ulyssessouza

@bwateratmsft
Copy link
Author

Looks like implementation in #43 is good. The Edge channel does not yet have ACI integration 0.1.18; is there something newer I can test with or should I just hold off for now?

@karolz-ms
Copy link

@gtardif said in an email:

we just released node-sdk v0.1.18 This includes APIs for volume management (list, create, delete) on ACI. It will require the docker ACI integration 0.1.18, coming with Docker Desktop 2.4.0.0 (Desktop stable)

So sounds like we should only enable the feature if the user has Desktop 2.4.0.0 or newer

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@gtardif @karolz-ms @bwateratmsft