Allow client to set boltdb timeout #140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sanimej
reviewed
Nov 9, 2016
| @@ -80,13 +81,15 @@ func New(endpoints []string, options *store.Config) (store.Store, error) { | |||
| if err != nil { | |||
| return nil, err | |||
| } | |||
| } else if options.ConnectionTimeout != 0 { | |||
| timeout = options.ConnectionTimeout | |||
There was a problem hiding this comment.
Lets make this unconditional because the options.ConnectionTimeout is used always. This way BoltDB.timeout will reflect the right value if at all it has to be used elsewhere.
- also in case of no persistent connection Signed-off-by: Alessandro Boch <[email protected]>
- To fix CI Signed-off-by: Alessandro Boch <[email protected]>
|
LGTM |
bryant1410
pushed a commit
to bryant1410/libkv
that referenced
this pull request
Apr 18, 2017
Allow client to set boltdb timeout Signed-off-by: Santiago Castro <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
.travis.ymlRelated to moby/moby#26251
Related to moby/libnetwork#1374
Supersedes #135
Signed-off-by: Alessandro Boch [email protected]