-
Notifications
You must be signed in to change notification settings - Fork 7.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update "select a storage driver" with current status #7669
Update "select a storage driver" with current status #7669
Conversation
ping @ahh-docker @bermudezmt @mataneja PTAL |
oh, and @L-Hudson 🤗 |
Deploy preview for docsdocker ready! Built with commit e7cbb50 |
@thaJeztah Mind if I take some edits at this before sending them off to @L-Hudson for review? |
@ahh-docker no, not at all; edit away; I started working on this, then saw the discussion that the docs team may started working on it, so I thought: let me push, and open as a PR. |
The information on this page was a bit outdated, and with "overlay" and "devicemapper" being phased-out, could use some changes; - de-emphasize "overlay", "devicemapper" and "aufs" - split "recommended" and "alternative drivers" columns (vfs was listed as a "recommended" driver, but definitely is not recommended for production use). - add notes about "overlay" and "devicemapper" being deprecated in Docker 18.09 - some other textual changes. Signed-off-by: Sebastiaan van Stijn <[email protected]>
d5baa72
to
3b24959
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
left two nits, but otherwise your changes look good to me 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
Asking @bermudezmt or @ddeyo for peer review. Once I get a LGTM, I'll merge. |
I spotted a few things that needed changing, and would like to get a review from @L-Hudson on the product naming especially around "Docker Engine Enterprise and Docker EE" and "Docker Engine Community and Docker CE". |
@L-Hudson: Please give your final review and edits. Once it's done, lemme know so we can merge. Please tag myself and @thaJeztah with any questions. Thanks! |
[Product compatibility matrix](https://success.docker.com/Policies/Compatibility_Matrix). | ||
To get commercial support from Docker, you must use a supported configuration. | ||
|
||
### Docker CE | ||
### Docker Engine Community and Docker CE |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
shd be "Docker Engine - Community"
|
||
For Docker CE, only some configurations are tested, and your operating system's | ||
kernel may not support every storage driver. In general, the following | ||
For Docker Engine Community, only some configurations are tested, and your operating |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
shd be "Docker Engine - Community"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed throughout.
Fixed product naming
The information on this page was a bit outdated, and with "overlay" and "devicemapper" being phased-out, could use some changes;
(vfs was listed as a "recommended" driver, but definitely
is not recommended for production use).
deprecated in Docker 18.09
Related issues (optional)