17.05 Edge docs #2996
17.05 Edge docs #2996
Conversation
|
@alexellis PTAL |
| read and maintain. | ||
|
|
||
| > **Acknowledgment**: | ||
| > Special thanks to Alex Ellis for granting permission to use his blog post |
There was a problem hiding this comment.
@mstanleyjones can you include a link out for the name?
+> Special thanks to Alex Ellis for granting permission to use his blog post
| contained everything needed to build your application), and a slimmed-down one | ||
| to use for production, which only contained your application and exactly what | ||
| was needed to run it. This has been referred to as the "builder | ||
| pattern".Maintaining two Dockerfiles is not ideal. |
There was a problem hiding this comment.
Should there be a space here between pattern".M ?
+pattern".Maintaining two Dockerfiles is not ideal.
| the `alpine:latest` image as its base. The `COPY --from=0` line copies just the | ||
| built artifact from the previous stage into this new stage. The Go SDK and any | ||
| intermediate artifacts are left behind, and not saved in the final image. | ||
|
|
There was a problem hiding this comment.
I'm wondering if we're missing some of the original context by not running the resulting image. Maybe we could include a quick example?
|
Addressed your feedback, @alexellis I also noticed in your example you don't clean up the extracted |
|
|
||
| echo Building alexellis2/href-counter:latest | ||
|
|
||
| docker build --no-cache -t alexellis2/href-counter:latest . |
There was a problem hiding this comment.
@mstanleyjones let's add an rm ./app here so that things are belt and braces. I think I just maintain a .gitignore.
|
For pruning - I don't think that's necessary for the intermediate image in the builder pattern, after all I think is also going to turn into a legacy way to build images and wouldn't normally be pushed anywhere. |
Proposed changes
Include Edge content for 17.05 release
Unreleased project version (optional)
Docker CE 17.05
Fixes #2755
Fixes #2999