Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ports and volumes long form syntax to compose-file reference #2283

Merged
merged 3 commits into from
Mar 28, 2017
Merged

Add ports and volumes long form syntax to compose-file reference #2283

merged 3 commits into from
Mar 28, 2017

Conversation

dnephin
Copy link
Contributor

@dnephin dnephin commented Mar 13, 2017

Also removes some references to the old format from the v3 reference.

Engine PR for mounts moby/moby#30597
Engine PR for ports moby/moby#30476

cc @shin- @thaJeztah @vdemeester @londoncalling

@dnephin dnephin mentioned this pull request Mar 13, 2017
Merged
@dnephin dnephin force-pushed the add-expanded-to-compose-ref branch from 8131494 to e51ff3e Compare March 13, 2017 18:36
@londoncalling
Copy link
Contributor

LGTM

@londoncalling
Copy link
Contributor

@dnephin I guess I'll wait to merge this until you merge the relevant code per docker/docker issue #30597 or feel free to merge it yourself.

@sixeyed
Copy link
Contributor

sixeyed commented Mar 13, 2017

@dnephin this doesn't actually a 3.2 compose version as you say in the note. The requirement is for Docker 17.04+. See PR 30476.

@dnephin
Copy link
Contributor Author

dnephin commented Mar 14, 2017

V3.2 is correct, see moby/moby#31795

vdemeester
vdemeester approved these changes Mar 14, 2017
View reviewed changes
Copy link
Contributor

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🐯

@londoncalling londoncalling merged commit add1325 into docker:master Mar 28, 2017
@londoncalling londoncalling mentioned this pull request Mar 28, 2017
Merged
@dnephin dnephin deleted the add-expanded-to-compose-ref branch March 28, 2017 04:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vdemeester vdemeester vdemeester approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dnephin @londoncalling @sixeyed @vdemeester