Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENGDOCS-2342 #21573

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

ENGDOCS-2342 #21573

wants to merge 6 commits into from

Conversation

aevesdocker
Copy link
Contributor

@aevesdocker aevesdocker commented Dec 5, 2024

Description

New DD CLI feature for 4.37. Followed the way docker debug was added to the CLI reference

Related issues or tickets

Reviews

  • Technical review
  • Editorial review
  • Product review

@github-actions github-actions bot added area/desktop Issue affects a desktop edition of Docker. E.g docker for mac area/cli Relates to the CLI client labels Dec 5, 2024
Copy link

netlify bot commented Dec 5, 2024

Deploy Preview for docsdocker ready!

Name Link
🔨 Latest commit 19975c3
🔍 Latest deploy log https://app.netlify.com/sites/docsdocker/deploys/6759b3f38871c6000881997f
😎 Deploy Preview https://deploy-preview-21573--docsdocker.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@aevesdocker aevesdocker added this to the 4.37 milestone Dec 5, 2024
@aevesdocker aevesdocker marked this pull request as ready for review December 5, 2024 13:48
Copy link

@Xeeynamo Xeeynamo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking care of documenting the desktop CLI commands. There are a few other options that needs to be added. But overall it looks good!

data/desktop-cli/docker_desktop_start.yaml Outdated Show resolved Hide resolved
data/desktop-cli/docker_desktop_restart.yaml Show resolved Hide resolved
data/desktop-cli/docker_desktop_stop.yaml Show resolved Hide resolved
@aevesdocker aevesdocker requested a review from dvdksn as a code owner December 11, 2024 15:02
@aevesdocker aevesdocker requested a review from a team December 11, 2024 15:04
Copy link

@Xeeynamo Xeeynamo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Leaving a few more comments on top of changes I did not notice on the first round of reviews

data/desktop-cli/docker_desktop_stop.yaml Outdated Show resolved Hide resolved
data/desktop-cli/docker_desktop_stop.yaml Outdated Show resolved Hide resolved
Comment on lines 28 to 29
value_type: string
default_value: '[]'

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
value_type: string
default_value: '[]'
value_type: int
default_value: 0

Comment on lines 18 to 19
value_type: stringArray
default_value: '[]'

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
value_type: stringArray
default_value: '[]'
value_type: bool
default_value: false

Comment on lines 27 to 28
value_type: string
default_value: '[]'

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
value_type: string
default_value: '[]'
value_type: int
default_value: 0

data/desktop-cli/docker_desktop_stop.yaml Outdated Show resolved Hide resolved
Comment on lines 18 to 19
value_type: stringArray
default_value: '[]'

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
value_type: stringArray
default_value: '[]'
value_type: bool
default_value: false

data/desktop-cli/docker_desktop_stop.yaml Outdated Show resolved Hide resolved
data/desktop-cli/docker_desktop_start.yaml Outdated Show resolved Hide resolved
data/desktop-cli/docker_desktop_start.yaml Outdated Show resolved Hide resolved

The Docker Desktop CLI provides:

- Enhanced automation and CI/CD integration: Perform Docker Desktop operations directly in CI/CD pipelines for better workflow automation.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Who in their right mind would use Docker Desktop in CI?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/cli Relates to the CLI client area/desktop Issue affects a desktop edition of Docker. E.g docker for mac status/review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants