Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Update a link in cpp/containerize.md #21134

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Pradumnasaraf
Copy link
Contributor

@Pradumnasaraf Pradumnasaraf commented Oct 16, 2024

Description

Update the sample repository link. Both container.md and develop.md previously had different links.

It would be better to keep my repo link for easier maintenance and updates, similar to Bun.

Reviews

  • Technical review
  • Editorial review
  • Product review

Copy link

netlify bot commented Oct 16, 2024

Deploy Preview for docsdocker ready!

Name Link
🔨 Latest commit 800aa39
🔍 Latest deploy log https://app.netlify.com/sites/docsdocker/deploys/670fd2e453f6790008902699
😎 Deploy Preview https://deploy-preview-21134--docsdocker.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

$ git clone https://github.com/dockersamples/c-plus-plus-docker.git
$ git clone https://github.com/Pradumnasaraf/c-plus-plus-docker.git
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, I think we should prefer to refer to the dockersamples organization's repositories. Same should go for the Bun guide.

@ajeetraina do you have superpowers to fork the repository for the Bun guide (https://github.com/Pradumnasaraf/bun-docker) to the dockersamples org?

@Pradumnasaraf
Copy link
Contributor Author

Pradumnasaraf commented Oct 16, 2024

Got it, @dvdksn. We should then prefer dockersamples. I have updated the link for the Bun guide as well. Once Ajeet is done with Forking, we can update guides by merging this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants