Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bake doc improvements #20245

Merged
merged 11 commits into from
Jun 24, 2024
Merged

bake doc improvements #20245

merged 11 commits into from
Jun 24, 2024

Conversation

dvdksn
Copy link
Collaborator

@dvdksn dvdksn commented Jun 17, 2024

Description

Assorted documentation improvements for the Buildx Bake documentation

Restructured the section and added more details about the various features / use cases that the Bake file supports.

This duplicates some content in the Bake reference, so I plan to do a follow-up to slim the reference doc down and link out to some of these pages where necessary.

Preview

@dvdksn dvdksn requested a review from crazy-max as a code owner June 17, 2024 12:36
@github-actions github-actions bot added the area/build Relates to Dockerfiles or docker build command label Jun 17, 2024
Copy link

netlify bot commented Jun 17, 2024

Deploy Preview for docsdocker ready!

Name Link
🔨 Latest commit ed78769
🔍 Latest deploy log https://app.netlify.com/sites/docsdocker/deploys/667922fa9ac5900008ef42ba
😎 Deploy Preview https://deploy-preview-20245--docsdocker.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@dvdksn dvdksn requested a review from colinhemmings June 17, 2024 12:38
@dvdksn dvdksn force-pushed the bake-doc-improvements branch from 34698e5 to 501fd7a Compare June 17, 2024 12:41
@dvdksn dvdksn force-pushed the bake-doc-improvements branch from 501fd7a to f0d81dc Compare June 17, 2024 13:46
@dvdksn dvdksn requested a review from a team June 17, 2024 13:53
@dvdksn dvdksn force-pushed the bake-doc-improvements branch from f0d81dc to 60f26f2 Compare June 17, 2024 13:57
Copy link
Contributor

@craig-osterhout craig-osterhout left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. A couple capitalization nits.

content/build/bake/matrices.md Outdated Show resolved Hide resolved
content/build/bake/compose-file.md Outdated Show resolved Hide resolved
Copy link
Member

@crazy-max crazy-max left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM nice work @dvdksn!

Let's get this one in. I will add another use case as follow-up to avoid duplicated context transfer using named context.

@crazy-max crazy-max merged commit 2b2eb44 into docker:main Jun 24, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/build Relates to Dockerfiles or docker build command status/review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants