ci: create placeholder file for new commands before validation #16771
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for docsdocker ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
jedevc
reviewed
Feb 24, 2023
| const yamlDestPath = path.join('_data', `${{ inputs.data-files-folder }}`, yamlSrcFilename); | ||
| const placeholderPath = path.join(dataFilesPlaceholderFolder, yamlSrcFilename.replace(/^docker_/, '').replace(/\.yaml$/, '.md')); | ||
| if (dataFilesPlaceholderFolder !== '' && !fs.existsSync(placeholderPath)) { | ||
| const placeholderContent = `---\ndatafolder: ${{ inputs.data-files-folder }}\ndatafile: ${yamlSrcFilename.replace(/\.[^/.]+$/, '')}\ntitle: ${yamlSrcFilename.replace(/\.[^/.]+$/, "").replaceAll('_', ' ')}\n---\n{% include cli.md datafolder=page.datafolder datafile=page.datafile %}`; |
There was a problem hiding this comment.
Could we split this up into multiple lines? Creating an array first, then joining with newlines?
It's a bit tricky to read at the moment.
There was a problem hiding this comment.
Could we split this up into multiple lines?
👍
Didn't want to waste time with templating or handlebars for this stuff but we can look at this in follow-up to clean this up a bit.
dvdksn
reviewed
Feb 24, 2023
Signed-off-by: CrazyMax <[email protected]>
crazy-max
force-pushed
the
fix-ci-validate-upstream
branch
from
40a2b9d to
f5ea254
Compare
dvdksn
approved these changes
Feb 24, 2023
jedevc
approved these changes
Feb 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Our
validate-upstreamworkflow does not take into account new commands that don't have (yet) a placeholder markdown file and therefore fails with https://github.com/docker/buildx/actions/runs/4262324143/jobs/7417733008#step:8:3742This change ensures a placeholder exists and creates it if it's not there.
Tested here: https://github.com/docker/buildx/actions/runs/4263151955/jobs/7419575907#step:7:38
Related issues (optional)
debug-shellandon-errorbuildx#1640 (comment)