Indicate extends can be used again #13695
Conversation
|
✔️ Deploy Preview for docsdocker ready! 🔨 Explore the source changes: 7db4fd8 🔍 Inspect the deploy log: https://app.netlify.com/sites/docsdocker/deploys/61695b7d898c6600072f5c35 😎 Browse the preview: https://deploy-preview-13695--docsdocker.netlify.app |
|
@ulyssessouza Could you PTAL? |
usha-mandya
added
the
area/compose
| @@ -179,7 +179,8 @@ $ docker-compose -f docker-compose.yml -f docker-compose.admin.yml \ | |||
| > of keys added and removed, along with information on [how to upgrade](compose-file/compose-versioning.md#upgrading). | |||
| > See [moby/moby#31101](https://github.com/moby/moby/issues/31101) to follow the | |||
| > discussion thread on the possibility of adding support for `extends` in some form in | |||
| > future versions. | |||
| > future versions. The `extends` keyword has been included in docker-compose versions 1.27 | |||
| > and higher. | |||
There was a problem hiding this comment.
Hello fellow documentation writers 👋
I didn't understand this when reading it. The info box firstly has info about how extends got added and later removed and how it's not supported in 3.x. Then a message that it's included in 1.27 and higher.
Is it possible that someone with good insights into this rewrites this box with a clear indication of which version range of Docker Compose that supports extends and which doesn't?
In 2021, @BretFisher wrote this nice summary:
There was a problem hiding this comment.
@benjaoming Thanks for the feedback. Agree that the note needs to clarify support for extends. Created an internal ticket to get this updated. Thank you.
There was a problem hiding this comment.
Thanks so much @usha-mandya ! It was the second time that I ran into the extends support issue. I wasn't able to correctly recall my experience about 4 months ago, so had to read through all the many comments one more time.
I think one of the important additions is also this one about how depends_on isn't possible in combination with extends.
Good luck and thanks, I will definitely need this part of the documentation again in a near future 💯
There was a problem hiding this comment.
@usha-mandya, IIUC - the extend should work on docker-compose version 1.27 and higher, and it's not related to the compose file format version? also, I saw here moby/moby#31101 (comment) that there is a recommendation to remove the version number at the beginning of the compose files, is it true?
docker/compose#7588
Proposed changes
Indicate availability of
extendsin docker-compose again.Related issues (optional)
moby/moby#31101
docker/compose#7588