-
Notifications
You must be signed in to change notification settings - Fork 7.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expand documentation for --secret
#13632
Conversation
✔️ Deploy Preview for docsdocker ready! 🔨 Explore the source changes: 35cd491 🔍 Inspect the deploy log: https://app.netlify.com/sites/docsdocker/deploys/61575219f94cb7000861e3f5 😎 Browse the preview: https://deploy-preview-13632--docsdocker.netlify.app |
@tonistiigi Could you PTAL? |
have the secret file: | ||
have the secret file._ | ||
|
||
The `type=secret` and `id` parameters are mandatory but the following optional |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
id is not mandatory if dst is set
have the secret file._ | ||
|
||
The `type=secret` and `id` parameters are mandatory but the following optional | ||
parameters are also available if desired: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not a complete list https://github.com/moby/buildkit/blob/master/frontend/dockerfile/docs/syntax.md#run---mounttypesecret
The `type=secret` and `id` parameters are mandatory but the following optional | ||
parameters are also available if desired: | ||
|
||
* `dst=<path>` - By default the secret file is created at `/run/secret/<id>` by |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We do support dst
for backwards compat with other flags that allowed ambiguity. But I think in examples we should normalize to target
Thanks for the pull request. We'd like to make our product docs better, but haven’t been able to review all the suggestions. If the updates are still relevant, review our contribution guidelines and rebase your pull request against the latest version of the docs, then mark it as fresh with a Prevent pull requests from auto-closing with a /lifecycle stale |
Proposed changes
Expanded the documentation for the
--secret
and--mount=type=secret
functions in the newbuildkit
/dockerfile 1.2
tooling.Direct link to rendered version
Related issues (optional)
Adds documentation for moby/buildkit#1534 (as well as more general documentation of the feature)