Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename Product Manuals to Manuals #13498

Merged
merged 2 commits into from
Sep 10, 2021
Merged

Conversation

usha-mandya
Copy link
Member

Signed-off-by: Usha Mandya [email protected]

Rename the section Product Manuals to Manuals in the light of the recent subscription updates

@usha-mandya
Copy link
Member Author

@thaJeztah Could you PTAL?

@netlify
Copy link

netlify bot commented Sep 10, 2021

✔️ Deploy Preview for docsdocker ready!

🔨 Explore the source changes: 81ecae7

🔍 Inspect the deploy log: https://app.netlify.com/sites/docsdocker/deploys/613b5a062c6185000738137b

😎 Browse the preview: https://deploy-preview-13498--docsdocker.netlify.app

thaJeztah
thaJeztah previously approved these changes Sep 10, 2021
Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

but hosted offerings can be products as well, right? 😇

I like shorter, so LGTM

(left one minor nit, not a show-stopper)

_includes/breadcrumbs.html Outdated Show resolved Hide resolved
Co-authored-by: Sebastiaan van Stijn <[email protected]>
Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@usha-mandya usha-mandya merged commit 4e120ba into docker:master Sep 10, 2021
@usha-mandya usha-mandya deleted the manuals-patch branch September 10, 2021 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants