-
Notifications
You must be signed in to change notification settings - Fork 7.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Compose command doc #12433
Compose command doc #12433
Conversation
Signed-off-by: Guillaume Tardif <[email protected]>
Deploy preview for docsdocker ready! Built with commit ffc980b |
c976f46
to
cfd9066
Compare
Signed-off-by: Guillaume Tardif <[email protected]>
cfd9066
to
7bacff3
Compare
@@ -0,0 +1,49 @@ | |||
--- |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This page appears as an orphan page - https://deploy-preview-12433--docsdocker.netlify.app/compose/cli-command-compatibility/. It must be linked from the toc.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought linking it from the compose tech preview page was OK. Is it mandatory to make it appear in the TOC. (fine for me if we prefer to link everything in TOC)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, we should ideally link it from the toc. If users land on this page, there's no context if they want to go back to a previous page, or select a different topic.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added Compose Tech preview compatibility
section just next to Compose CLI Tech Preview
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we make 'Compatibility' as a subsection of 'Compose CLI'? I am concerned that having two separate Tech Preview sections in TOC may make it seem like there are two separate Tech Previews...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yea, agree. We can add that as a subsection.
c99483c
to
14121a0
Compare
Co-authored-by: Usha Mandya <[email protected]>
14121a0
to
9e5cd1b
Compare
Co-authored-by: Usha Mandya <[email protected]>
0f30a88
to
d4628b9
Compare
Signed-off-by: Guillaume Tardif <[email protected]>
d4628b9
to
937e7cd
Compare
Signed-off-by: Guillaume Tardif <[email protected]>
661b0f9
to
a5b1f25
Compare
As suggested on https://github.com/docker/docker.github.io/issues/12454, CLI reference should include a |
@@ -0,0 +1,49 @@ | |||
--- |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we make 'Compatibility' as a subsection of 'Compose CLI'? I am concerned that having two separate Tech Preview sections in TOC may make it seem like there are two separate Tech Previews...
Signed-off-by: Guillaume Tardif <[email protected]>
I rephrased it
(having a subsection on a real page is a bit cumbersome) |
Agreed, but can be done as a separate PR on top of this one. |
Signed-off-by: Guillaume Tardif <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks @gtardif
Proposed changes
Add presentation of the compose in docker CLI command, and compatibility list with docker-compose
Does not yet include updates on the compose install part