buildx: add add -ldflags=-linkmode=external to fix missing build-id warning #531
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…arning
I noticed this warning during a build in CI:
warning: Missing build-id in /root/rpmbuild/BUILDROOT/docker-ce-cli-0.0.0.20210311145359.d3c36a2-0.el8.x86_64/usr/libexec/docker/cli-plugins/docker-buildx
And looks looks like we had that issue before at some point; rpm-software-management/rpm#367 (comment)
From that thread:
> OK one way is to use gccgo instead of go build, and the other way is to add -ldflags=-linkmode=external flag to go build.
>
> Still, by default (i.e. using go build) it doesn't do that and it's a problem.
Signed-off-by: Sebastiaan van Stijn <[email protected]>
|
First run (with test-commit to "revert" the fix); https://ci-next.docker.com/public/blue/rest/organizations/jenkins/pipelines/docker-ce-packaging/branches/PR-531/runs/1/nodes/9/log/?start=0 |
thaJeztah
force-pushed
the
fix_missing_build_id_warning
branch
from
f557814 to
1b9e75a
Compare
|
With this patch, no warning is shown; https://ci-next.docker.com/public/blue/rest/organizations/jenkins/pipelines/docker-ce-packaging/branches/PR-531/runs/2/nodes/9/log/?start=0 |
|
@tonistiigi @tiborvass ptal |
Closed
Closed
|
This file was removed, so this no longer applies |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed this warning during a build in CI on #530:
And looks looks like we had that issue before at some point; rpm-software-management/rpm#367 (comment)
From that thread: