Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[18.09] Add explicit dependency for libseccomp2 #172

Merged
merged 1 commit into from
Aug 29, 2018

Conversation

dhiltgen
Copy link
Contributor

While testing on older ubuntu images we discovered
we do depend on a newer version of libseccomp2.

Signed-off-by: Daniel Hiltgen [email protected]

While testing on older ubuntu images we discovered
we do depend on a newer version of libseccomp2.

Signed-off-by: Daniel Hiltgen <[email protected]>
@andrewhsu andrewhsu changed the title Add explicit dependency for libseccomp2 [18.09] Add explicit dependency for libseccomp2 Aug 29, 2018
@andrewhsu
Copy link
Contributor

For reference, ubuntu xenial shipped with 2.2.3 whereas xenial-updates has 2.3.1:
https://packages.ubuntu.com/search?keywords=libseccomp2

Copy link
Contributor

@andrewhsu andrewhsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andrewhsu andrewhsu merged commit f0a0c5a into docker:18.09 Aug 29, 2018
@andrewhsu
Copy link
Contributor

Hmm...just noticed this, but it also means debian jessie will not work because it has libseccomp2 2.2:
https://packages.debian.org/search?keywords=libseccomp2

Will work on stretch, tho.

@dhiltgen
Copy link
Contributor Author

debian jessie will not work

Hmm... that implies it's already broken since we're compiling/linking with the newer library with incompatible symbols. Given the current state of the build rigging, I think the dep is probably "more right" than before, but we might want to down-rev the base builder image to the lowest common denominator and then verify it is forward compatible so we can soften the dependency for the TP6.

@dhiltgen
Copy link
Contributor Author

I'll hold off forward porting this to master until we figure out what strategy we want to take to address older distros.

@johanneswuerbach
Copy link

This seems also to have broken installing docker-ce on ubuntu trusty / 14.04, which only has libseccomp2 v2.1.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants